Page 1 of 1

can't copy carrier - width is also incorrect.

PostPosted: Mon Oct 17, 2022 3:59 am
by subkiisp
Version: 2.14b0.5
SVN Version: 3647
DB Schema Version: 1667
DB Schema Update Date: 2022-10-16 15:44:51

Hello,
just installed vicibox 9.0.3 - all working good but just noticed, copying carrier is not working.. also on few menu the width bar is strange.
please see the picture and update in next svn please.

Image
Image

Re: can't copy carrier - width is also incorrect.

PostPosted: Mon Oct 17, 2022 6:51 am
by jamiemurray
Copy carrier is broken confirmed.
Line 14955 of admin.php from SVN source at 3647
Code: Select all
$stmt="INSERT INTO vicidial_server_carriers (carrier_id,carrier_name,registration_string,template_id,account_entry,protocol,globals_string,dialplan_entry,server_ip,active,carrier_description,user_group,conf_engine,conf_update_interval) SELECT \"$carrier_id\",\"$carrier_name\",registration_string,template_id,account_entry,protocol,globals_string,dialplan_entry,\"$server_ip\",\"N\",carrier_description,user_group,conf_engine,conf_update_interval from vicidial_server_carriers where carrier_id=\"$source_carrier\";";


It should be:
Code: Select all
$stmt="INSERT INTO vicidial_server_carriers (carrier_id,carrier_name,registration_string,template_id,account_entry,protocol,globals_string,dialplan_entry,server_ip,active,carrier_description,user_group) SELECT \"$carrier_id\",\"$carrier_name\",registration_string,template_id,account_entry,protocol,globals_string,dialplan_entry,\"$server_ip\",\"N\",carrier_description,user_group from vicidial_server_carriers where carrier_id=\"$source_carrier\";";


Posted in bug tracker: http://www.vicidial.org/VICIDIALmantis/view.php?id=1384

Re: can't copy carrier - width is also incorrect.

PostPosted: Mon Oct 17, 2022 8:29 am
by subkiisp
also there is a width problems too.. window size on few menu is larger than normal vicidial page.

Re: can't copy carrier - width is also incorrect.

PostPosted: Mon Oct 17, 2022 12:23 pm
by jamiemurray
The carrier copy function has been fixed in SVN 3648.
As for the widths varying, this is purely cosmetic and is usually due to large fields or report content on the page being viewed, if you want to make it uniform, consider providing a patch in the bug tracker against the most recent SVN code but to be honest, it wouldn't bring much value IMO.