Optimization of lookup_gmt function

Discussions about development of VICIDIAL and astGUIclient

Moderators: gerski, enjay, williamconley, Op3r, Staydog, gardo, mflorell, MJCoate, mcargile, Kumba, Michael_N

Optimization of lookup_gmt function

Postby IgorG » Tue Mar 09, 2010 5:21 am

Hello,

While profiling vicidial on huge list loading I have found, that function lookup_gmt, that called for every lead, take much time for execution. Main reason - it includes every time when called dbconnect.php, and cause reading astguiclient.conf reading.

I have improved this place by changing include(dbconnect.php) to global $link, as soon as $link to database is the only data needed from dbconnect.php. Does this change proper and can it be committed to feature version of vicidial?
IgorG
 
Posts: 21
Joined: Fri Apr 24, 2009 3:56 am
Location: Russia, Omsk

Postby mflorell » Tue Mar 09, 2010 7:09 am

Please submit your patch and documentation to the issue tracker and post a link on this thread.
mflorell
Site Admin
 
Posts: 18341
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby IgorG » Tue Mar 09, 2010 7:30 am

IgorG
 
Posts: 21
Joined: Fri Apr 24, 2009 3:56 am
Location: Russia, Omsk

Postby mflorell » Tue Mar 09, 2010 9:11 am

Fixed in SVN trunk and 2.2.0

This gave an estimated 40% reduction in time to load leads in my tests.
mflorell
Site Admin
 
Posts: 18341
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby williamconley » Tue Mar 09, 2010 2:01 pm

whoa. way to go IgorG.
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20019
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)


Return to Development

Who is online

Users browsing this forum: No registered users and 18 guests