Viciphone 2.0

[mcargile]

I have Viciphone 2.0 working in Chrome and Firefox (at least on the 3 PCs I have tested so far). Would love some community feedback. If you are interested in testing it please do the following:

Change your WebRTC Template in Vicidial to this:

type=friend
host=dynamic
encryption=yes
icesupport=yes
directmedia=no
transport=wss
dtlsenable=yes
dtlsverify=no
dtlscertfile=/PATH/TO/YOUR/SSL/CERT
dtlsprivatekey=/PATH/TO/YOU/SSL/KEY
dtlssetup=actpass
rtcp_mux=yes

Then in System Setting change the Webphone URL to:

https://dev.viciphone.com/v2/viciphone.php

Everything all other configurations should be the same as version one. As I have said I have only tested this on 3 PCs so I recommend that you try this on a test dialer and not on a production system.

[dspaan]

What are the changes/improvements compared to v1?

[mcargile]

It uses the new SIP.js library which is very different. It also has the potential to support MS Edge.

[ccabrera]

Michael,

Could you please publish this new code under a new branch in Github? I'll love to check out the new code and see whats new.

[williamconley]

Michael,

Could you please publish this new code under a new branch in Github? I'll love to check out the new code and see whats new.

He'll be doing that AFTER he's finished with this round of testing. That's precisely the point of this post. He doesn't want to deal with 200 guys posting the same flaws to the code he's already working on. It's annoying to deal with that sort of thing, and he wants to see the activity in HIS server first so he can see what needs to be fixed before release.

Respect the coders methods, his work is excellent.

[ccabrera]

William, I believe that is the reason for which GitHub was created: Share code so that others may review, suggest, even improve.

He doesn't need to work on all the flaws by himself. We could help too, but for that we need to be able to join while the product is being built, not after.

As for the flaws he's already working on, that's completely understandable. But then again: GitHub has an issue tracker which would allow anyone to have a closer and more detailed follow up of whatever he's coding.

So what I'm saying is: there's some of us who want to contribute in developing, not just testing, and for that, we need to see code while it's being written.

Let us help.

[williamconley]

Yes, but not during initial build-out. During initial buildout, proof of concept and prototype stages, it's common to keep it in-house and not something you argue about with a technician who will be publishing the final prototype when it's ready.

He likes to get to "I think it works" and request bug checking after it's fully operational. I'll never argue with that approach on a free project (or bug the guy who has the code prematurely: If he wanted to publish his GIT already he would have).

lol: The rough equivalent of hearing "are we there yet?" from the back seat. IMHO

[dspaan]

I tested in chrome and it worked fine. Also tested in Edge but didn't get any audio and after 1 min the message there was no connection with my phone. Edge did ask me if my microphone could be used. Anything specific you wanted me to test?

[dspaan]

Also, can you add different ringtones for the webphone?

[mcargile]

I will be releasing the code on github once I am positive everything is working correctly. With regards to Edge, I am not bothering with finalizing that till they get their core switched over to Chromium. At which point I am 99% sure it will just work. As for the ringtones, I am happy to switch them, but we need an audio file that is is released under a compatible license which was hard to find in the first place.

[williamconley]

I will be releasing the code on github once I am positive everything is working correctly. With regards to Edge, I am not bothering with finalizing that till they get their core switched over to Chromium. At which point I am 99% sure it will just work. As for the ringtones, I am happy to switch them, but we need an audio file that is is released under a compatible license which was hard to find in the first place.

just a place for the ringtone would be fine, even if it's always got the same filename in it. the ability to set the ringtone to a file in the audio store would be perfect.

[mcargile]

Honestly do not see this being added any time soon unless someone paid for it. This is mainly because it would require a ton of work in the agent interface of Vicidial to pass the option to Viciphone and Matt is swamped with paid development.

In other news the Canary build of Edge based off Chromium was just released and it works flawlessly with Viciphone.

[williamconley]

Honestly do not see this being added any time soon unless someone paid for it. This is mainly because it would require a ton of work in the agent interface of Vicidial to pass the option to Viciphone and Matt is swamped with paid development.

In other news the Canary build of Edge based off Chromium was just released and it works flawlessly with Viciphone.

ah, well. putting a note of where that file could be modified somewhere in the code for the lay-people wouldn't be bad either, if it's not too troublesome. Or here. Here is good, too.

[dspaan]

Honestly do not see this being added any time soon unless someone paid for it. This is mainly because it would require a ton of work in the agent interface of Vicidial to pass the option to Viciphone and Matt is swamped with paid development.

In other news the Canary build of Edge based off Chromium was just released and it works flawlessly with Viciphone.

ah, well. putting a note of where that file could be modified somewhere in the code for the lay-people wouldn't be bad either, if it's not too troublesome. Or here. Here is good, too.

Good idea.

[mcargile]

The files is called ringing.mp3 and is in the sounds directory.

This is the line in vici_phone.js where that is set:

Code: Select all

// setup the ringing audio file
ringAudio = new Audio('sounds/ringing.mp3');


I am open to suggestions on how to make this more "lay-people" friendly than it already is.

[dspaan]

You're right, that's already very simple.

[williamconley]

perfect. if someone wants to pull that from a settings container or something it'll be easy enough to code for their call center. in the meantime, just editing the js file will suffice for those who care (and they'll just have to remember to update it whenever they upgrade).

[dspaan]

Michael, can you please take a look at this topic: viewtopic.php?f=4&t=39066&p=139116

[dreedy]

I am toying around with it on our test dialer here and it looks a lot more complete. I am seeing that ICE and STUN are making connections with less complaints on the code level in the console.

[dspaan]

When will viciphone 2.0 be released in Github so it can be used in production?
I can still only download 1.0.0 from 2 years ago.